[PATCH] D87013: [DebugInfo] Fix emitting pre-v5 name lookup tables in the DWARF64 format (6/19).

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 13:56:34 PDT 2020


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good, thanks! (with the test expanded a bit, as mentioned)



================
Comment at: llvm/test/DebugInfo/X86/debug-pubtables-dwarf64.ll:6-15
+; CHECK:      .debug_pubnames contents:
+; CHECK-NEXT: length = 0x0000000000000026, format = DWARF64, version = 0x0002, unit_offset =
+; CHECK-NEXT: Offset     Name
+; CHECK-NEXT: 0x{{([[:xdigit:]]{16})}} "foo"
+
+; CHECK:      .debug_pubtypes contents:
+; CHECK-NEXT: length = 0x0000000000000032, format = DWARF64, version = 0x0002, unit_offset =
----------------
Expand this test to verify that the offsets parsed from debug_pub* match the offsets of the DIEs they are meant to refer to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87013/new/

https://reviews.llvm.org/D87013



More information about the llvm-commits mailing list