[PATCH] D87032: [AMDGPU] Remove the dead spill slots while spilling FP/BP to memory

[Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits]

RamNalamothu added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:126
+      LLVM_DEBUG(dbgs() << "Reserved FI " << FrameIndex << " for spilling "
+                        << (IsFP ? "FP" : "BP") << "\n");
     }
----------------
arsenm wrote:
> Single quotes around \n
Done.


================
Comment at: llvm/test/CodeGen/AMDGPU/callee-frame-setup.ll:466
 ; GCN: v_mov_b32_e32 [[TMP_VGPR1:v[0-9]+]], s33
-; GCN: buffer_store_dword [[TMP_VGPR1]], off, s[0:3], s32 offset:[[OFF:[0-9]+]]
 ; GCN: s_mov_b64 exec, [[COPY_EXEC1]]
----------------
arsenm wrote:
> Why start hardcoding this?
To ensure we are getting correct/expected stack offset here after the removal of dead spill slots.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87032/new/

https://reviews.llvm.org/D87032