[PATCH] D87034: [KnownBits] Implement accurate unsigned and signed max and min

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 12:07:48 PDT 2020


foad added inline comments.


================
Comment at: llvm/include/llvm/Support/KnownBits.h:178
+  /// value is known to be greater than or equal to Val.
+  KnownBits makeGE(APInt Val) const;
+
----------------
nikic wrote:
> `const APInt &`?
Could do, but then I'd need to copy it in the implementation before calling clearLowBits. I don't know which is best.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87034/new/

https://reviews.llvm.org/D87034



More information about the llvm-commits mailing list