[PATCH] D84547: [ConstraintElimination] Add constraint elimination pass.

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/Analysis/ConstraintSystem.h:60
+    }
+    assert(Constraints.empty() || R.size() == Constraints.back().size());
+    for (auto &C : R) {
----------------
Call addVariableRow() instead of duplicating the code?


================
Comment at: llvm/lib/Transforms/Scalar/ConstraintElimination.cpp:177
+  // come before blocks and conditions dominated by them. If a block and a
+  // condition have the same numbers, the conditions comes before the block, as
+  // it holds on entry to the block.
----------------
conditions -> condition


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84547/new/

https://reviews.llvm.org/D84547