[PATCH] D87003: [llvm-cov] Allow commas in filenams passed to `-object` flag

[Andrew Gallagher via Phabricator via llvm-commits]

andrewjcg created this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
andrewjcg requested review of this revision.

Currently, `-object` takes a comma separated list of objects as an
argument, which prevents it working with path names that contain a
comma.  Drop comma-separated support, which requires to set pass the
`-object` flag multiple times to set multiple objects.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87003

Files:
  llvm/tools/llvm-cov/CodeCoverage.cpp


Index: llvm/tools/llvm-cov/CodeCoverage.cpp
===================================================================
--- llvm/tools/llvm-cov/CodeCoverage.cpp
+++ llvm/tools/llvm-cov/CodeCoverage.cpp
@@ -544,8 +544,7 @@
       cl::Positional, cl::desc("Covered executable or object file."));
 
   cl::list<std::string> CovFilenames(
-      "object", cl::desc("Coverage executable or object file"), cl::ZeroOrMore,
-      cl::CommaSeparated);
+      "object", cl::desc("Coverage executable or object file"), cl::ZeroOrMore);
 
   cl::list<std::string> InputSourceFiles(
       cl::Positional, cl::desc("<Source files>"), cl::ZeroOrMore);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87003.289354.patch
Type: text/x-patch
Size: 631 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200902/8bafcd0c/attachment.bin>