[PATCH] D86383: [GlobalISel] Fold xor(cmp(pred, _, _), 1) -> cmp(inverse(pred), _, _)

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 15:41:36 PDT 2020


rupprecht added a comment.

Thanks!

Usually, tests that are marked `# REQUIRES: asserts` are done so because they make use of some code that is only available behind `NDEBUG`. However, in this case, it's outright crashing on certain inputs when not in debug mode. At a first glance, that doesn't seem like a correct fix to me -- after all, the crashing bug is still there -- but I'm not familiar with this code, so I'm probably missing something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86383/new/

https://reviews.llvm.org/D86383



More information about the llvm-commits mailing list