[PATCH] D85524: [Loads] Add canReplacePointersIfEqual helper.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks!



================
Comment at: llvm/include/llvm/Analysis/Loads.h:166
+bool canReplacePointersIfEqual(Value *A, Value *B, const DataLayout &DL,
+                               Instruction *CtxI);
 }
----------------
aqjune wrote:
> Would it be better if it starts with `CanReplace...`?
I think https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly suggests starting function names with lowercases. The functions in this file seem to mix both upper and lower case first characters. Given that I think it is slightly better to go with the suggestion in the docs. But I am happy to change post-commit if I am missing something and upper case would be better!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85524/new/

https://reviews.llvm.org/D85524