[PATCH] D86905: Flush bitcode incrementally for LTO output
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 1 12:16:38 PDT 2020
MaskRay added inline comments.
================
Comment at: llvm/include/llvm/Support/raw_ostream.h:318
+
+ virtual Kinds get_kind() const;
+
----------------
stephan.yichao.zhao wrote:
> MaskRay wrote:
> > https://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html
> >
> > We usually use static `classof`
> Thank you.
> I implemented classof. then dyn_cast works!
> But I did not make kind as a class member initialized at constructor like that link does. Making that change will change lots of code at different child classes. Is the way that kind is defined in the link a requirement in LLVM codebase?
Can `Kind` use a default member initializer?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86905/new/
https://reviews.llvm.org/D86905
More information about the llvm-commits
mailing list