[PATCH] D86907: Fix for PR46384. Failure on weak dllimport.

[Warren Ristow via Phabricator via llvm-commits]

wristow added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:593
+    Assert((GV.isDeclaration() &&
+            (GV.hasExternalLinkage() || GV.hasExternalWeakLinkage())) ||
                GV.hasAvailableExternallyLinkage(),
----------------
This relaxation of the assertion-check LGTM.


================
Comment at: llvm/test/Verifier/weak-dllimport.ll:1
+; RUN: opt -verify < %s
+; ModuleID = 'wd.cpp'
----------------
This test seems somewhat complicated.  Can it be simplified significantly, and still trigger the problem?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86907/new/

https://reviews.llvm.org/D86907