[llvm] ca233be - [llvm-readobj][test] - Remove amdgpu-elf-definitions.test

Georgii Rymar via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 04:05:08 PDT 2020


Author: Georgii Rymar
Date: 2020-09-01T14:04:14+03:00
New Revision: ca233be2f0a6623d835d33f1453d3248448ba606

URL: https://github.com/llvm/llvm-project/commit/ca233be2f0a6623d835d33f1453d3248448ba606
DIFF: https://github.com/llvm/llvm-project/commit/ca233be2f0a6623d835d33f1453d3248448ba606.diff

LOG: [llvm-readobj][test] - Remove amdgpu-elf-definitions.test

`amdgpu-elf-definitions.test` is a file that tests
`Format`, 'OS/ABI' and 'Machine' fields printed for EM_AMDGPU.
It uses a precompiled object.

It is not needed to have it, because:
1) We already test formats in `file-header-format.test` + `llvm/unittests/Object/ELFObjectFileTest.cpp`.
2) We test 'OS/ABI' in `file-header-os-abi.test` for all possible values.
3) We test machine types in `file-header-machine-types.test`

In addition we have `amdgpu-elf-headers.test` which tests EM_AMDGPU specific flags. I.e.
it also tests the fact that llvm-readobj/elf are able to dump such objects.

This patch removes the test case and the corresponding binary.

Differential revision: https://reviews.llvm.org/D86774

Added: 
    

Modified: 
    

Removed: 
    llvm/test/tools/llvm-readobj/ELF/Inputs/trivial.obj.elf-amdhsa-gfx803
    llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-definitions.test


################################################################################
diff  --git a/llvm/test/tools/llvm-readobj/ELF/Inputs/trivial.obj.elf-amdhsa-gfx803 b/llvm/test/tools/llvm-readobj/ELF/Inputs/trivial.obj.elf-amdhsa-gfx803
deleted file mode 100644
index 421269cbd8b2..000000000000
Binary files a/llvm/test/tools/llvm-readobj/ELF/Inputs/trivial.obj.elf-amdhsa-gfx803 and /dev/null 
diff er

diff  --git a/llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-definitions.test b/llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-definitions.test
deleted file mode 100644
index 19627378094e..000000000000
--- a/llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-definitions.test
+++ /dev/null
@@ -1,11 +0,0 @@
-# RUN: llvm-readobj --file-headers -l -S --symbols %p/Inputs/trivial.obj.elf-amdhsa-gfx803 | FileCheck %s
-
-# CHECK: Format: elf64-amdgpu
-# CHECK: Arch: unknown
-# CHECK: ElfHeader {
-# CHECK:   Ident {
-# CHECK:     OS/ABI: AMDGPU_HSA (0x40)
-# CHECK:     ABIVersion: 0
-# CHECK:   }
-# CHECK:   Machine: EM_AMDGPU (0xE0)
-# CHECK: }


        


More information about the llvm-commits mailing list