[PATCH] D86918: [DebugInfo] Simplify string table dumpers.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I would suggest merging debug-str.yaml and debug-str-dwo.yaml. The only difference is the section name. You could even show that both are dumped if in the same input file.

I think keeping .debug_line_str separate is still wise, because it uses a different switch to get dumped. I don't feel strongly about it though, so am happy if others think it should be merged into a single test. I don't have an answer about what to do about the duplicate coverage of the escaping stuff.



================
Comment at: llvm/test/tools/llvm-dwarfdump/debug-str.yaml:1
-## Show that llvm-dwarfdump dumps the .debug_str section when --debug-str is
+## a) Show that llvm-dwarfdump dumps the .debug_str section when --debug-str is
 ## specified.
----------------
My same comments apply here as in D86916.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86918/new/

https://reviews.llvm.org/D86918