[PATCH] D86916: [llvm-dwarfdump][test] Add tests for dumping the .debug_line_str section.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

It sounds to me like the .debug_line_str should be using the same dumper as the .debug_str and .debug_str.dwo dumpers. There's no difference in the section format as far as I'm aware.



================
Comment at: llvm/test/tools/llvm-dwarfdump/debug-line-str.yaml:4
+# RUN: yaml2obj -DCONTENT="616263006362610000" %s -o %t1.o
+##                        "abc\0cba\0\0"
+# RUN: llvm-dwarfdump --debug-line-str %t1.o | FileCheck %s --check-prefix=LINE-STR
----------------
I'd put this comment above the RUN line. Same below.


================
Comment at: llvm/test/tools/llvm-dwarfdump/debug-line-str.yaml:23
+
+## b) Test how we dump nonprintable chars.
+
----------------



================
Comment at: llvm/test/tools/llvm-dwarfdump/debug-line-str.yaml:26
+# RUN: yaml2obj -DCONTENT="090001005C30303100" %s -o %t2.o
+##                        "\t\0\001\\001"
+# RUN: llvm-dwarfdump --debug-line-str %t2.o | FileCheck %s --check-prefix=ESCAPED
----------------
It might be clearer if this comment was divided into individual characters. It took me several attempts to figure it out. (Maybe do `'\t', '\0', '\001', '\\', '0', '0', '1'`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86916/new/

https://reviews.llvm.org/D86916