[PATCH] D86912: [DebugInfo] Remove Dwarf5AccelTableWriter::Header::UnitLength. NFC.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 23:49:10 PDT 2020


ikudrin created this revision.
ikudrin added reviewers: labath, dblaikie, aprantl, jhenderson.
ikudrin added projects: LLVM, debug-info.
Herald added a subscriber: hiraditya.
ikudrin requested review of this revision.

The member is not in use; the unit length for the table is emitted as a difference between two labels. Moreover, the type of the member might be misleading, because for DWARF64 the field should be 64 bit long.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86912

Files:
  llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp


Index: llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp
===================================================================
--- llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp
+++ llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp
@@ -190,7 +190,6 @@
 template <typename DataT>
 class Dwarf5AccelTableWriter : public AccelTableWriter {
   struct Header {
-    uint32_t UnitLength = 0;
     uint16_t Version = 5;
     uint16_t Padding = 0;
     uint32_t CompUnitCount;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86912.289083.patch
Type: text/x-patch
Size: 449 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200901/da3eed5b/attachment.bin>


More information about the llvm-commits mailing list