[PATCH] D86894: [SVE] Disable INSERT_SUBVECTOR DAGCombine for scalable vectors

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 16:23:52 PDT 2020


cameron.mcinally added a comment.

I don't really have an opinion on any of this. Just thinking aloud...

If we did go with operator%, I'm not sure it's much more wrong than operator/ for scalable vector types. Assuming that the users are checking for `EC % X == 0`, we should be conservatively correct checking `MIN % X == 0`.

It would be nice if we didn't need to rewrite all the % uses to `ElementCount::divisibleBy(unsigned)` in existing code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86894/new/

https://reviews.llvm.org/D86894



More information about the llvm-commits mailing list