[PATCH] D86889: [AArch64] Add asm directives for the remaining SEH unwind codes

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 13:21:19 PDT 2020


efriedma added a comment.

Adding assembler support for the basic opcodes we left out because the code generator doesn't use them seems fine.  We could teach the assembler to optimize certain constructs: for example, turn save_regp_x into save_r19r20_x if the register matches and the offset is in range.  Might be more confusing than helpful, though.

For the custom stack opcodes, do you have some intended use?  If we just want to allow people to dump random bytes into the unwind opcode list, we could add a directive for that, without trying to come up with an appropriate name for opcodes that aren't really documented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86889/new/

https://reviews.llvm.org/D86889



More information about the llvm-commits mailing list