[PATCH] D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

Side note: This `get_test_cc_for_arch` function is bad in multiple ways.

- `${arch} MATCHES "arm|aarch64"` doesn't mean cross compilation. I'm guessing this was s a "good enough" heuristic at the time.
- For Apple platforms it assumes macOS. Which is necessarily correct.

This function should probably just check if `COMPILER_RT_TEST_COMPILER` and `COMPILER_RT_TEST_COMPILER_CFLAGS` are set and then have the convention globally that these are only set when doing cross-compilation and the compiler and testing flags need overriding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86379/new/

https://reviews.llvm.org/D86379