[PATCH] D86859: [Coroutine] Properly deal with alloca spills

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 11:03:13 PDT 2020


lxfind planned changes to this revision.
lxfind added inline comments.


================
Comment at: llvm/test/Transforms/Coroutines/ArgAddr.ll:50
 ; CHECK-NEXT: call void @print(i32 4)
+; CHECK-NEXT: call void @llvm.lifetime.end.p0i8(i64 4, i8* nonnull %0)
 ; CHECK-NEXT: call void @print(i32 3)
----------------
Looks like this is incorrect. It doesn't work well when CoroSaves are in loops. I will look into this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86859/new/

https://reviews.llvm.org/D86859



More information about the llvm-commits mailing list