[PATCH] D85911: libclc: spirv: Add various functions

Mon Aug 31 08:15:02 PDT 2020

daniels added a comment.

In D85911#2247480 <https://reviews.llvm.org/D85911#2247480>, @jvesely wrote:

> Why does this need a special implementation of fma.cl and fma.inc? The fp64 paths are missing, is there an expectation that something else will translate `fma(double)` function calls to `llvm.fma` opcodes?

D89510 should explain it: if we have precise hardware fma (e.g. on NV hardware) we want to be able to pass through to the hardware opcode, but if not we need to fall back to the slow & huge (but precise) software implementation. We want to expose which is in use back into libclc, so e.g. sin/cos can generate better code when using the software variant.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85911/new/

https://reviews.llvm.org/D85911