[PATCH] D86610: [ELF] Add new EM called EM_CSKY

Zixuan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 30 19:48:16 PDT 2020


zixuan-wu added a comment.
Herald added a subscriber: danielkiss.

In D86610#2241879 <https://reviews.llvm.org/D86610#2241879>, @arsenm wrote:

> In D86610#2239950 <https://reviews.llvm.org/D86610#2239950>, @MaskRay wrote:
>
>> This looks good to me, but I guess the target may need an official approval (from LLVM Foundation Board of Directors?) first.
>
> I don't think it's necessary to hold up this patch on anything like that. It would be reasonable to define the reserved enum values independently of the target

The test `ELFObjectFileTest.cpp` depends on the `Triple::csky` so it would be follow-up of triple patch if that patch is representing the target acceptance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86610/new/

https://reviews.llvm.org/D86610



More information about the llvm-commits mailing list