[PATCH] D86843: [EarlyCSE] Equivalent SELECTs should hash equally

[Bryan Chan via Phabricator via llvm-commits]

bryanpkc added a comment.

In D86843#2246700 <https://reviews.llvm.org/D86843#2246700>, @lebedev.ri wrote:

> In D86843#2246699 <https://reviews.llvm.org/D86843#2246699>, @bryanpkc wrote:
>
>> In D86843#2246545 <https://reviews.llvm.org/D86843#2246545>, @lebedev.ri wrote:
>>
>>> 1. As a preparatory patch, we should adjust every test that uses EarlyCSE to also specify `-earlycse-debug-hash`, at least to those where it doesn't result in an assertion
>>
>> Thanks for your suggestions, Roman. I have added the reproducer to the EarlyCSE tests, next to other similar test cases. Regarding your first suggestion, do you mean that we should enable `-earlycse-debug-hash` in all tests under `llvm/test/Transforms/EarlyCSE/`, or even all tests under `llvm/test/` that may implicitly use `EarlyCSE`?
>
> At least for every test that explicitly uses `-early-cse`.
>
>> That seems like overkill.
>
> OTOH these bugs aren't fun, and they should be trivially caught by existing tests, since the test coverage should be good anyways.

OK, I will submit a second patch to do that, as well as the `EXPENSIVE_CHECKS` change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86843/new/

https://reviews.llvm.org/D86843