[PATCH] D86395: InstCombine transform pattern "(~A & B) ^ A -> (A | B)" added

[Jaydeep Chauhan via Phabricator via llvm-commits]

Jac1494 added a comment.
Herald added a subscriber: danielkiss.

In D86395#2242393 <https://reviews.llvm.org/D86395#2242393>, @spatel wrote:

> You are proposing to transform 4 commuted variations of a pattern, but your tests do not provide coverage for those variants. My test suggestion would hopefully provide that coverage. 
> This might be clearer if you create the tests before this code patch and step through the transforms in a debugger. Look for InstCombinerImpl::SimplifyAssociativeOrCommutative() and getComplexity().

@spatel ,Thank you so much for such informative reply. Now anything is pending in review which need to be update?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86395/new/

https://reviews.llvm.org/D86395