[llvm] 9c1ca8a - [NFC][InstCombine] select.ll: remove outdated TODO comment

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 29 05:11:13 PDT 2020


Author: Roman Lebedev
Date: 2020-08-29T15:10:13+03:00
New Revision: 9c1ca8a3f7c5bda04405da761c7a59b1d5b1a129

URL: https://github.com/llvm/llvm-project/commit/9c1ca8a3f7c5bda04405da761c7a59b1d5b1a129
DIFF: https://github.com/llvm/llvm-project/commit/9c1ca8a3f7c5bda04405da761c7a59b1d5b1a129.diff

LOG: [NFC][InstCombine] select.ll: remove outdated TODO comment

Fixed by 3e69871ab5a66fb55913a2a2f5e7f5b42899a4c9

Added: 
    

Modified: 
    llvm/test/Transforms/InstCombine/select.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/InstCombine/select.ll b/llvm/test/Transforms/InstCombine/select.ll
index aa5472ef43b8..0ac9c699b1dd 100644
--- a/llvm/test/Transforms/InstCombine/select.ll
+++ b/llvm/test/Transforms/InstCombine/select.ll
@@ -1903,7 +1903,6 @@ exit:
 }
 
 ; Shows how we can leverage dominance to eliminate duplicating selects.
-; TODO: We can optimize further if we eliminate duplicating Phis and similify the whole thing to phi[x, y] * 3.
 define i32 @select_dominance_chain(i1 %cond, i32 %x, i32 %y) {
 ; CHECK-LABEL: @select_dominance_chain(
 ; CHECK-NEXT:  entry:


        


More information about the llvm-commits mailing list