[PATCH] D83608: [NewPM][CodeGen] Introduce CodeGenPassBuilder to help build codegen pipeline

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 28 12:36:17 PDT 2020


ychen marked 2 inline comments as done.
ychen added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/CodeGenPassBuilder.h:211
+    // implementation to accommodate that.
+    Optional<bool> AddingFunctionPasses;
+  };
----------------
arsenm wrote:
> I don't understand why this is optional
I was thinking of making this check optional. Seems not needed for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83608/new/

https://reviews.llvm.org/D83608



More information about the llvm-commits mailing list