[PATCH] D86687: [DAGCombiner] Enhance (zext(setcc))

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/hoist-and-by-const-from-lshr-in-eqcmp-zero.ll:314
 ;------------------------------------------------------------------------------;
 ; A few negative tests
 ;------------------------------------------------------------------------------;
----------------
spatel wrote:
> lkail wrote:
> > xbolva00 wrote:
> > > Adjust comment?
> > Hmmm, interesting, the function name also indicates it's negative.
> Yes, please update comment.
> https://alive2.llvm.org/ce/z/AEzNaw
> Side note: in IR, -instcombine doesn't get this, but -sccp does.
"negative" in this context means the test was trying to show that the icmp transform that applies to other tests in this file is not applicable to this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86687/new/

https://reviews.llvm.org/D86687