[PATCH] D86319: [Attributor] Introduce module slice.

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 28 07:47:19 PDT 2020


sstefan1 added inline comments.


================
Comment at: llvm/test/Transforms/Attributor/IPConstantProp/musttail-call.ll:100
 ; IS__CGSCC____-NEXT:    [[I1:%.*]] = call i32 @external()
-; IS__CGSCC____-NEXT:    ret i8* null
+; IS__CGSCC____-NEXT:    unreachable
 ;
----------------
okura wrote:
> jdoerfert wrote:
> > This looks wrong though. Need to verify.
> This is because of AANoUndef implementation. I have made a patch for this.  D86396
Thanks again for taking a look!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86319/new/

https://reviews.llvm.org/D86319



More information about the llvm-commits mailing list