[PATCH] D86774: [llvm-readobj][test] - Remove amdgpu-elf-definitions.test

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: kerbowa, rupprecht, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar requested review of this revision.
Herald added a subscriber: wdng.

`amdgpu-elf-definitions.test` is a file that tests
`Format`, 'OS/ABI' and 'Machine' fields printed for EM_AMDGPU.
It uses a precompiled object.

It is not needed to have it, because:

1. We already test formats in `file-header-format.test` + `llvm/unittests/Object/ELFObjectFileTest.cpp`.
2. We test 'OS/ABI' in `file-header-os-abi.test` for all possible values.
3. We test machine types in `file-header-machine-types.test`

In addition we have `amdgpu-elf-headers.test` which tests EM_AMDGPU specific flags. I.e.
it also tests the fact that llvm-readobj/elf are able to dump such objects.

This patch removes the test case and the corresponding binary.


https://reviews.llvm.org/D86774

Files:
  llvm/test/tools/llvm-readobj/ELF/Inputs/trivial.obj.elf-amdhsa-gfx803
  llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-definitions.test


Index: llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-definitions.test
===================================================================
--- llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-definitions.test
+++ /dev/null
@@ -1,11 +0,0 @@
-# RUN: llvm-readobj --file-headers -l -S --symbols %p/Inputs/trivial.obj.elf-amdhsa-gfx803 | FileCheck %s
-
-# CHECK: Format: elf64-amdgpu
-# CHECK: Arch: unknown
-# CHECK: ElfHeader {
-# CHECK:   Ident {
-# CHECK:     OS/ABI: AMDGPU_HSA (0x40)
-# CHECK:     ABIVersion: 0
-# CHECK:   }
-# CHECK:   Machine: EM_AMDGPU (0xE0)
-# CHECK: }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86774.288579.patch
Type: text/x-patch
Size: 570 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200828/c579f396/attachment.bin>