[PATCH] D86050: [SCEV] Refactor isHighCostExpansionHelper

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp:2218-2220
+  switch (S->getSCEVType()) {
+  default:
+    return 0;
----------------
lebedev.ri wrote:
> I'm sorry, but i don't like this.
> The old code would loudly fail should anyone introduce a new SCEV type and forget to update this,
> new code will silently treat such a case as free.
Ah, good point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86050/new/

https://reviews.llvm.org/D86050