[PATCH] D85159: [ConstProp] Remove ConstantPropagation

[Arthur Eubanks via llvm-commits]

Yeah InstSimplify really should be used anywhere ConstProp is being used,
adding C bindings for it in https://reviews.llvm.org/D86764.

On Thu, Aug 27, 2020 at 11:10 PM Roland Scheidegger via Phabricator <
reviews at reviews.llvm.org> wrote:

> sroland added a comment.
>
> mesa/llvmpipe was using this pass, so it doesn't build anymore. If the
> proposed replacement is the InstSimplifyLegacyPass that's fine, however the
> old one was nicely available via the c interface
> (LLVMAddConstantPropagationPass) whereas the InstSimplifyLegacyPass is not.
> (I'd note that we only use very few passes, and they are perhaps not
> optimal, but the goal is to avoid any expensive passes while still getting
> some optimization. So, not really insisting on InstSimplifyLegacyPass
> neither if there are other suitable replacements doing roughly the same
> thing - it would be nice though if we'd not have to do our own c++ wrapper
> as we try to avoid that when possible.)
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D85159/new/
>
> https://reviews.llvm.org/D85159
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200828/742fba0f/attachment.html>