[PATCH] D69411: [MC] Resolve the difference of symbols in consecutive MCDataFragements

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/MC/MCFragment.h:74
+  // the fragment is not in any subsection
+  unsigned SubsectionNumber = 0;
+
----------------
jcai19 wrote:
> MaskRay wrote:
> > Move below LayoutOrder. sizeof(MCDataFragment) will not change
> > 
> > Alternatively, disable the folding for Mach-O because this is too subtle (if getSubsectionViaSymbols())
> Thanks for all the comments! Can you please elaborate this one? Are you suggesting to move SubsectionNumber right after LayoutOrder?
`SubsectionNumber` looks too subtle. I'd hope we just remove the variable, and avoid the computation for Mach-O.

Happy to hear what @jyknight will say, and whether this is a reasonable (imperfect) approach. Personally I think it is mostly good if `SubsectionNumber` is removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69411/new/

https://reviews.llvm.org/D69411