[PATCH] D86521: Revert "Use find_library for ncurses"

Harmen Stoppels via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 14:33:28 PDT 2020


haampie added a comment.

@phosek it would be great to get that patch in, but the truth is it is difficult testing across multiple platforms for me; I can only test on Linux and macOS, not Windows (GNU). Since that patch would touch predefined, platform-dependent cmake variables, I would want to test it properly before submitting a patch, which might take a bit more time. So for me it would be best to temporarily accept this reverting patch, and submit a properly tested patch afterwards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86521/new/

https://reviews.llvm.org/D86521



More information about the llvm-commits mailing list