[PATCH] D86634: [AMDGPU] SILowerControlFlow::optimizeEndCF should remove empty basic block

Alexander via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 12:43:05 PDT 2020


alex-t added a comment.

In D86634#2240606 <https://reviews.llvm.org/D86634#2240606>, @arsenm wrote:

> Should also add a few cases with other empty block situations, including with debug info.
>
> Also should add an example where the original problem occurred

All the above in fact are covered in collapse-encf.mir
As for the original problem, it is mostly about placing the spills in the redundant block under exec == 0.
CFG in this example is trivial if-break loop exit and also covered by the existing test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86634/new/

https://reviews.llvm.org/D86634



More information about the llvm-commits mailing list