[PATCH] D86724: [BuildLibCalls] Add argmemonly to more lib calls.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 12:16:26 PDT 2020


jdoerfert added a comment.

In D86724#2242825 <https://reviews.llvm.org/D86724#2242825>, @efriedma wrote:

>> I broke out strcoll, because the result depends on the locale, which might get accessed through memory.
>
> Aren't strcasecmp/strncasecmp also locale-sensitive?

Hm, not clear to me:

>   The POSIX.1-2008 standard says of these functions:
>    
>          When the LC_CTYPE category of the locale being used is from  the
>          POSIX locale, these functions shall behave as if the strings had
>          been converted to lowercase and  then  a  byte  comparison  per‐
>          formed.  Otherwise, the results are unspecified.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86724/new/

https://reviews.llvm.org/D86724



More information about the llvm-commits mailing list