[PATCH] D86701: [LLD] [COFF] Error out if creating a DLL with too many exported symbols

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

The change looks fine.

For testing, I like the idea of one function exported with 64K names.  What about an object file that has just one function, and a module-definition file (.DEF file) that exports 64K aliases of it at link time?  The .DEF file would be about as large as your generated .c file is now, but the object file would be tiny.

I'd have no concerns about generating the test inputs on demand--that's done quite a bit for the debugger tests--but lld is not my baby.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86701/new/

https://reviews.llvm.org/D86701