[PATCH] D86696: [Attributor][WIP] Introduce Loop AA

[Kuter Dinel via Phabricator via llvm-commits]

kuter added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:7948-7952
+          if (KnownState.contains(APInt(1, 1)))
+            KnownAELoops.insert(L);
+          else if (KnownState.isFullSet())
+            MayNELoops.insert(L);
+        }
----------------
kuter wrote:
> I don't think this is correct.
> for known endless, range can contain 1 if the range is in [0,1].
> I don't think you can prove a loop is endless by looking at the range (except for it always being 0)
> IMHO you should look at the SCEV, what does other people think ? 
> @jdoerfert 
I am sorry I ment never endless. in the 3th line phab won't let me change the inline comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86696/new/

https://reviews.llvm.org/D86696