[PATCH] D84220: [IPSCCP] Fix a bug that the "returned" attribute is not cleared when function is optimized to return undef

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.

LGTM, thanks.  Just a minor comment about the comments. Also, could you add the blockaddress case to `llvm/test/Transforms/SCCP/ipsccp-clear-returned.ll`?



================
Comment at: llvm/lib/Transforms/Scalar/SCCP.cpp:2044
     ReturnsToZap[i]->setOperand(0, UndefValue::get(F->getReturnType()));
+    // Record all functions that are zapped
+    FuncZappedReturn.insert(F);
----------------
nit: period at end of sentence. (here and at the other comments)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84220/new/

https://reviews.llvm.org/D84220