[PATCH] D86625: [unittests/Object] - Add testing for missing ELF formats.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 02:36:03 PDT 2020


grimar added a comment.

In D86625#2239298 <https://reviews.llvm.org/D86625#2239298>, @MaskRay wrote:

> `llvm/test/tools/llvm-objcopy/ELF/cross-arch-headers.test` contains some tests as well, e.g. sparc. Should we remove some redundant targets there?

`llvm/test/tools/llvm-objcopy/ELF/cross-arch-headers.test` tests `-O` (--output-format) option of `llvm-objcopy`.

I probably do not see why any of those tests are really redundant. I think it is not the same as D86350 <https://reviews.llvm.org/D86350> for `llvm-readobj`, where we are really able to test
just a few values printed for "Format" field, because the latter one is directly related with the `getFileFormatName`, which is tested here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86625/new/

https://reviews.llvm.org/D86625



More information about the llvm-commits mailing list