[PATCH] D86350: [llvm-readobj][test] - Test "Format" values.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 00:05:16 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/file-header-format.test:1
+## This testss "Format" values printed by llvm-readobj.
+
----------------



================
Comment at: llvm/test/tools/llvm-readobj/ELF/file-header-format.test:27
+  Type:    ET_REL
+  Machine: [[MACHINE]]
----------------
If you're going to use the default for CLASS and DATA, I'd do the same for MACHINE too, with EM_NONE as the default. Up to you though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86350/new/

https://reviews.llvm.org/D86350



More information about the llvm-commits mailing list