[PATCH] D86635: [Attributor] Add getter of abstract attributes for the manifestation stage

Wed Aug 26 12:52:43 PDT 2020

okura added a comment.

In D86635#2239738 <https://reviews.llvm.org/D86635#2239738>, @kuter wrote:

> I think rather than creating a new api function,  it would be more robust if we had a flag as member of the attributor.
> It would be similar to `SeedingPeriod` flag that I have added.
>
> Simply we would make it true in the `Attributor::manifestAttributes` function and then we would have a assertion in `Attributor::updateAA`

Thank you for the suggestion. I'm thinking about the same approach. I totally agree with @kuter. It is slightly hard for us to guarantee Attributor not to update AAs during manifestation by adding a new API.
Adding a flag that indicates which stage of the process (e.g. the update stage or the manifestation stage) we are in is better, I think.  
@jdoerfert How do you think about this?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86635/new/

https://reviews.llvm.org/D86635