[PATCH] D85159: [ConstProp] Remove ConstantPropagation

Wed Aug 26 12:36:54 PDT 2020

nikic added a comment.

Can you please also move `Analysis/ConstantFolding/*` and `Other/2002-03-11-ConstPropCrash.ll` into `Transforms/InstSimplify`?

================
Comment at: llvm/test/Transforms/Inline/externally_available.ll:1
-; RUN: opt < %s -inline -constprop -S | FileCheck %s

----------------
I'd drop the `-constprop` from this test entirely and regenerate check lines. It doesn't really look relevant.

================
Comment at: llvm/test/Transforms/Reassociate/2002-05-15-SubReassociate.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -reassociate -constprop -instcombine -dce -S | FileCheck %s
+; RUN: opt < %s -reassociate -instsimplify -instcombine -dce -S | FileCheck %s

----------------
The `-instsimplify` here can probably just dropped (instcombine already does instsimplify internally). Same for the other llvm/test/Transforms/Reassociate tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85159/new/

https://reviews.llvm.org/D85159