[PATCH] D85946: [InstSimplify] Simplify to vector constants when possible

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 11:24:37 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment.



================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4569
+  if (Op0Const && Op1Const)
+    if (auto *Res = ConstantExpr::getShuffleVector(Op0Const, Op1Const, Mask))
+      return Res;
----------------
ConstantExpr::getShuffleVector can't return null.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85946/new/

https://reviews.llvm.org/D85946



More information about the llvm-commits mailing list