[PATCH] D86579: Add lld/ELF release notes for release/11.x

[Peter Smith via Phabricator via llvm-commits]

psmith added a comment.

Thanks for putting this together, looks good. I've added a few suggestions, and some typo spots.



================
Comment at: lld/docs/ReleaseNotes.rst:37
+  (`D74887 <https://reviews.llvm.org/D74887>`_)
 * New ``--time-trace`` option records a time trace file that can be viewed in
   chrome://tracing. The file can be specified with ``--time-trace-file``.
----------------
Is it worth starting with the option first. Something like:
``--time-trace`` option has been added. It records...



================
Comment at: lld/docs/ReleaseNotes.rst:43
+  (`D80406 <https://reviews.llvm.org/D80406>`_)
+* ``--unique`` is added to create separate output sections.
+  (`D75536 <https://reviews.llvm.org/D75536>`_)
----------------
Suggest: is added to create separate output sections for orphan sections.


================
Comment at: lld/docs/ReleaseNotes.rst:45
+  (`D75536 <https://reviews.llvm.org/D75536>`_)
+* ``--warn-backrefs`` gets improved to emulate GNU ld's archive semantics. If a
+  link passes but not with ``--warn-backrefs``, it almost assuredly means that
----------------
"gets" -> "has been"


================
Comment at: lld/docs/ReleaseNotes.rst:46
+* ``--warn-backrefs`` gets improved to emulate GNU ld's archive semantics. If a
+  link passes but not with ``--warn-backrefs``, it almost assuredly means that
+  the link mail fail with GNU ld. ``--warn-backrefs-exclude=`` was added to exclude known issues.
----------------
Suggest: "If a link passes with warnings from ``--warn-backrefs``"


================
Comment at: lld/docs/ReleaseNotes.rst:47
+  link passes but not with ``--warn-backrefs``, it almost assuredly means that
+  the link mail fail with GNU ld. ``--warn-backrefs-exclude=`` was added to exclude known issues.
+  (`D77522 <https://reviews.llvm.org/D77522>`_)
----------------
typo "mail" -> "will" or "may"


================
Comment at: lld/docs/ReleaseNotes.rst:51
+  (`D77512 <https://reviews.llvm.org/D77512>`_)
+* ``--no-relax`` was added and ignored. The Linux kernel's RISC-V port uses this option.
+  (`D81359 <https://reviews.llvm.org/D81359>`_)
----------------
Suggest "is accepted but ignored"


================
Comment at: lld/docs/ReleaseNotes.rst:64
+* ``-z keep-text-section-prefix`` moves ``.text.unknown.*`` input sections to ``.text.unknown``.
+* ``-z rel`` and ``-z rela`` were added to support REL/RELA dynamic relocations.
+* ``-z start-stop-visibility={default,protected,internal,hidden}`` was added.
----------------
I think this is more along the lines of
"were added to select the REL/RELA format for the dynamic relocations. The default is target specific and typically matches the form used in relocatable objects."


================
Comment at: lld/docs/ReleaseNotes.rst:69
+* When ``-r`` or ``--emit-relocs`` is specified, the GNU ld compatible
+  ``--discard-all`` are ``--discard-locals`` semantics are implemented.
+  (`D77807 <https://reviews.llvm.org/D77807>`_)
----------------
are -> and


================
Comment at: lld/docs/ReleaseNotes.rst:71
+  (`D77807 <https://reviews.llvm.org/D77807>`_)
+* ``--emit-relocs --strip-debug`` can be used together.
+  (`D74375 <https://reviews.llvm.org/D74375>`_)
----------------
can now be used together.


================
Comment at: lld/docs/ReleaseNotes.rst:89
+  (`D74375 <https://reviews.llvm.org/D74375>`_)
+* ``INPUT_SECTION_FLAGS`` is supported.
+  (`D72745 <https://reviews.llvm.org/D72745>`_)
----------------
Suggest: ``INPUT_SECTION_FLAGS`` is supported in linker scripts.


================
Comment at: lld/docs/ReleaseNotes.rst:95
+  (`D86263 <https://reviews.llvm.org/D86263>`_)
+* ``SHT_GNU_verneed`` in shared objects are parsed and versioned undefined symbols in shared objects are respected.
+  (`D80059 <https://reviews.llvm.org/D80059>`_)
----------------
Does this need a comma after parsed.
``SHT_GNU_verneed`` in shared objects are parsed, and versioned undefined symbols in shared objects are respected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86579/new/

https://reviews.llvm.org/D86579