[PATCH] D84923: [ARM] Fix so immediates and pc relative checks

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:287
+      case ARM::LEApcrel:
+        return 4;
+      case ARM::t2LEApcrel:
----------------
simonwallis2 wrote:
> dmgreen wrote:
> > Why 4 and not 8? I think it's meant to be "2 instructions widths"
> Value of 4 was determined empirically.
You fill me with confidence. And would 8 empirically have problems too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84923/new/

https://reviews.llvm.org/D84923