[PATCH] D85137: [PowerPC] Add Support for PPC750 Paired Single ext

Charlotte Delenk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 03:06:13 PDT 2020


DarkKirb updated this revision to Diff 287892.
DarkKirb added a comment.

[PowerPC] Add Test for Paired Single Decoding

      

This has uncovered multiple bugs with my previous implementation, namely that
ps_res and ps_frsqte had the wrong opcode and that the decoding for
immediate-offset loads and stores in ps_l* and ps_st* caused internal compiler
errors.

      

I couldn't reuse the logic from other immediate-offset code because

1. The register and the offset field are not right next to each other
2. The currently existing memri* asm operands are not 12 bit with unaligned offsets.

This commit also fixes the test suite for powerpc as it puts the new
instructions into a separate namespace (called Paired).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85137/new/

https://reviews.llvm.org/D85137

Files:
  llvm/lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
  llvm/lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp
  llvm/lib/Target/PowerPC/PPCInstrFormats.td
  llvm/lib/Target/PowerPC/PPCInstrInfo.td
  llvm/lib/Target/PowerPC/PPCInstrPaired.td
  llvm/test/MC/Disassembler/PowerPC/ppc32-paired.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85137.287892.patch
Type: text/x-patch
Size: 23972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200826/d2456458/attachment-0001.bin>


More information about the llvm-commits mailing list