[PATCH] D86341: [llvm-readobj/elf][test] - Add testing for EM_* specific OS/ABI values.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1336-1339
+static const EnumEntry<unsigned> SymVersionFlags[] = {
+    {"Base", "BASE", VER_FLG_BASE},
+    {"Weak", "WEAK", VER_FLG_WEAK},
+    {"Info", "INFO", VER_FLG_INFO}};
----------------
I'd be inclined to move this further, e.g. to be near where they are used, or at least at the bottom of this block of `EnumEntry` arrays, since this is still sandwiched between different things that are ELF header specific.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86341/new/

https://reviews.llvm.org/D86341