[PATCH] D81500: [SVE] Remove calls to VectorType::getNumElements from IR

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 02:03:11 PDT 2020


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - but please be on the look out to help with assertions raised by theis series of changes - the oss fuzzer in particular will find many of these: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25165



================
Comment at: llvm/lib/IR/IRBuilder.cpp:527
+  auto PtrsTy = cast<FixedVectorType>(Ptrs->getType());
   auto PtrTy = cast<PointerType>(PtrsTy->getElementType());
   unsigned NumElts = PtrsTy->getNumElements();
----------------
please can you make these auto* to avoid a clang-tidy warning


================
Comment at: llvm/lib/IR/IRBuilder.cpp:557
+  auto PtrsTy = cast<FixedVectorType>(Ptrs->getType());
+  auto DataTy = cast<FixedVectorType>(Data->getType());
   unsigned NumElts = PtrsTy->getNumElements();
----------------
please can you make these auto* to avoid a clang-tidy warning


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81500/new/

https://reviews.llvm.org/D81500



More information about the llvm-commits mailing list