[PATCH] D86543: [lld][ELF][test] Expand testing of symbols in mergeable sections

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: lld/test/ELF/merge-gc-sym.s:1
+# REQUIRES: x86
+## Show how symbols in GCed mergeable pieces behave.
----------------
MaskRay wrote:
> Thanks for adding coverage. There are `gc-sections-merge*.s`. Can you check whether these tests can be reorganized?
The `gc-sections-merge*.s` tests all are testing how difference reference variations cause mergeable pieces to be discarded. The three tests essentially translate into using R_X86_64_64 with no addend, R_X86_64_64 with an addend that could be confused with referencing the next piece, and R_X86_64_PC32, where the implicit addend could again cause the same confusion. These are all useful behaviours to test, and are independent of the impact on symbols in mergeable pieces. I think they belong as separate tests consequently (although perhaps renaming them/adding comments to explain things more explicitly might be worthwhile?).

What sort of reorganization did you have in mind?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86543/new/

https://reviews.llvm.org/D86543