[llvm] b07d78b - [MC] [Win64EH] Update the AArch64/seh.s test slightly. NFC.

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 23:38:35 PDT 2020


Author: Martin Storsjö
Date: 2020-08-26T09:38:11+03:00
New Revision: b07d78bcf91a650e6b940600259d0e58120f783f

URL: https://github.com/llvm/llvm-project/commit/b07d78bcf91a650e6b940600259d0e58120f783f
DIFF: https://github.com/llvm/llvm-project/commit/b07d78bcf91a650e6b940600259d0e58120f783f.diff

LOG: [MC] [Win64EH] Update the AArch64/seh.s test slightly. NFC.

Update the comment stating the aim of the test - this is currently
only checking that these assembler directives doesn't cause the
assembler to fail, but the results of the testcase aren't particularly
correct yet.

Remove bits of the testcase that are even less likely to be found in
the wild (the .seh_startchained/.seh_endchained block), where the
testcase currently doesn't really generate anything interesting
anyway.

Differential Revision: https://reviews.llvm.org/D86524

Added: 
    

Modified: 
    llvm/test/MC/AArch64/seh.s

Removed: 
    


################################################################################
diff  --git a/llvm/test/MC/AArch64/seh.s b/llvm/test/MC/AArch64/seh.s
index eb6a94a3f737..2f4e3f27255f 100644
--- a/llvm/test/MC/AArch64/seh.s
+++ b/llvm/test/MC/AArch64/seh.s
@@ -1,4 +1,4 @@
-// This test checks that the SEH directives emit the correct unwind data.
+// This test checks that the SEH directives don't cause the assembler to fail.
 
 // RUN: llvm-mc -triple aarch64-pc-win32 -filetype=obj %s | llvm-readobj -S -r - | FileCheck %s
 
@@ -15,7 +15,7 @@
 // CHECK-NEXT:   }
 // CHECK:        Section {
 // CHECK:          Name: .xdata
-// CHECK:          RawDataSize: 24
+// CHECK:          RawDataSize: 20
 // CHECK:          RelocationCount: 1
 // CHECK:          Characteristics [
 // CHECK-NEXT:       ALIGN_4BYTES
@@ -25,7 +25,7 @@
 // CHECK-NEXT:   }
 // CHECK:        Section {
 // CHECK:          Name: .pdata
-// CHECK:          RelocationCount: 6
+// CHECK:          RelocationCount: 4
 // CHECK:          Characteristics [
 // CHECK-NEXT:       ALIGN_4BYTES
 // CHECK-NEXT:       CNT_INITIALIZED_DATA
@@ -41,10 +41,8 @@
 // CHECK-NEXT:   Section (5) .pdata {
 // CHECK-NEXT:     0x0 IMAGE_REL_ARM64_ADDR32NB func
 // CHECK-NEXT:     0x4 IMAGE_REL_ARM64_ADDR32NB .xdata
-// CHECK-NEXT:     0x8 IMAGE_REL_ARM64_ADDR32NB func
+// CHECK-NEXT:     0x8 IMAGE_REL_ARM64_ADDR32NB smallFunc
 // CHECK-NEXT:     0xC IMAGE_REL_ARM64_ADDR32NB .xdata
-// CHECK-NEXT:     0x10 IMAGE_REL_ARM64_ADDR32NB smallFunc
-// CHECK-NEXT:     0x14 IMAGE_REL_ARM64_ADDR32NB .xdata
 // CHECK-NEXT:   }
 // CHECK-NEXT: ]
 
@@ -65,9 +63,6 @@ func:
     .seh_handlerdata
     .long 0
     .text
-    .seh_startchained
-    .seh_endprologue
-    .seh_endchained
     add sp, sp, #24
     ret
     .seh_endproc


        


More information about the llvm-commits mailing list