[PATCH] D86541: Preserve vcc_lo when shrinking V_CNDMASK

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 17:30:23 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:3432
+
+      Use.setReg(Orig.getReg());
       Use.setIsUndef(Orig.isUndef());
----------------
This seems like the wrong place to set this. This implies the registers were mismatched before, and this should be fixed up when the shrunk instruction is created (I guess setting it here isn't that much different)

The way we handle wave32 vs. wave64 is super gross, and we really should have separate instructions. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86541/new/

https://reviews.llvm.org/D86541



More information about the llvm-commits mailing list