[PATCH] D86462: [llvm-readelf][test] - Refine the sections-ext.test

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Other than the inline comment, LG



================
Comment at: llvm/test/tools/llvm-readobj/ELF/sections-ext.test:193
+# RUN:   FileCheck %s -DFILE=%t --check-prefix=NO-SECTIONS
+# RUN: llvm-readobj --section-symbols %t | FileCheck %s -DFILE=%t --check-prefix=NO-SECTIONS
+# RUN: llvm-readobj --section-relocations %t | FileCheck %s -DFILE=%t --check-prefix=NO-SECTIONS
----------------
grimar wrote:
> jhenderson wrote:
> > MaskRay wrote:
> > > Can the three RUN lines be combined into one?
> > They are combined into one (see the line above). I don't think we need the individual versions personally.
> > I don't think we need the individual versions personally.
> 
> These are independent options still, even when we test them in a "3 in 1" test.
> I can easily imagine a broken code which will fail or crash or leave uncovered places or whatever with
> one of options, but not with 3. It is just safer to cover them independently. So, I'd keep all of them.
The 3 options extend --sections and do independent things. I still feel that one 3-in-1 RUN line is sufficient...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86462/new/

https://reviews.llvm.org/D86462