[llvm] 22cd6be - [llvm-libtool-darwin] Address post-commit feedback

Shoaib Meenai via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 15:04:33 PDT 2020


Author: Shoaib Meenai
Date: 2020-08-25T15:04:23-07:00
New Revision: 22cd6bee4a7d2cd106efe2879cc16ef94b671de1

URL: https://github.com/llvm/llvm-project/commit/22cd6bee4a7d2cd106efe2879cc16ef94b671de1
DIFF: https://github.com/llvm/llvm-project/commit/22cd6bee4a7d2cd106efe2879cc16ef94b671de1.diff

LOG: [llvm-libtool-darwin] Address post-commit feedback

Address James Henderson's comments on https://reviews.llvm.org/D86359.

Added: 
    

Modified: 
    llvm/docs/CommandGuide/llvm-libtool-darwin.rst
    llvm/test/tools/llvm-libtool-darwin/version.test

Removed: 
    


################################################################################
diff  --git a/llvm/docs/CommandGuide/llvm-libtool-darwin.rst b/llvm/docs/CommandGuide/llvm-libtool-darwin.rst
index a3c7aba6cf50..6be849a22fd7 100644
--- a/llvm/docs/CommandGuide/llvm-libtool-darwin.rst
+++ b/llvm/docs/CommandGuide/llvm-libtool-darwin.rst
@@ -76,9 +76,13 @@ OPTIONS
 
   Use actual timestamps and UIDs/GIDs.
 
+.. option:: -V
+
+  Display the version of this program and perform any operation specified.
+
 .. option:: -version
 
-  Display the version of this program.
+  Display the version of this program and exit immediately.
 
 EXIT STATUS
 -----------

diff  --git a/llvm/test/tools/llvm-libtool-darwin/version.test b/llvm/test/tools/llvm-libtool-darwin/version.test
index 7bbaf1cfdbdb..6ed0a1172665 100644
--- a/llvm/test/tools/llvm-libtool-darwin/version.test
+++ b/llvm/test/tools/llvm-libtool-darwin/version.test
@@ -4,20 +4,20 @@
 ## cctools libtool, which silences all argument parsing errors when -V is
 ## specified).
 
-## Test -V by itself
+## Test -V by itself.
 # RUN: llvm-libtool-darwin -V | FileCheck %s
 ## The specific version number, vendor string, etc. will 
diff er across
 ## environments, so this is the most specific we can get.
 # CHECK: LLVM version
 
-## Parsing errors should not be surfaced when no operation is specified
+## Parsing errors should not be surfaced when no operation is specified.
 # RUN: llvm-libtool-darwin -V -D -U | FileCheck %s
 
-## Regular errors should occur when an operation is specified
+## Regular errors should occur when an operation is specified.
 # RUN: not llvm-libtool-darwin -V -static 2>&1 | FileCheck --check-prefix=ERROR %s
 # ERROR: for the -o option: must be specified
 
-## A valid command line should print the version and perform the operation
+## A valid command line should print the version and perform the operation.
 # RUN: yaml2obj %S/Inputs/input1.yaml -o %t-input1.o
 # RUN: yaml2obj %S/Inputs/input2.yaml -o %t-input2.o
 # RUN: llvm-libtool-darwin -static -o %t.lib %t-input1.o %t-input2.o -V | FileCheck %s


        


More information about the llvm-commits mailing list